chore(astro,clerk-js): Inject windowNavigate through router functions
#3922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases (like in Astro) we want to reconstruct the original windowNavigate functionality, that is because the framework might not have a router.
🦋 Changeset detectedLatest commit: 3d9c1b3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tmilewski
approved these changes
Aug 13, 2024
anagstef
approved these changes
Aug 13, 2024
octoper
approved these changes
Aug 13, 2024
…ndownavigate-from-astro # Conflicts: # packages/astro/src/internal/create-clerk-instance.ts
panteliselef
deleted the
elef/eco-50-refactor-duplicate-windownavigate-from-astro
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In some cases (like in Astro) we want to reconstruct the original windowNavigate functionality, that is because the framework might not have a router.
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change