fix(nextjs): Update imports to avoid Node.js build warnings on edge runtime#3661
Merged
LauraBeatris merged 4 commits intomainfrom Jul 4, 2024
Merged
fix(nextjs): Update imports to avoid Node.js build warnings on edge runtime#3661LauraBeatris merged 4 commits intomainfrom
LauraBeatris merged 4 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 00b7447 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
LauraBeatris
force-pushed
the
fix/use-als-global
branch
from
8820281 to
8d49c3a
Compare
brkalow
approved these changes
Jul 3, 2024
LauraBeatris
changed the title
AsyncLocalStorage as global for edge runtime AsyncLocalStorage as global for edge runtime
LauraBeatris
force-pushed
the
fix/use-als-global
branch
from
f3eb38d to
8d49c3a
Compare
LauraBeatris
changed the title
AsyncLocalStorage as global for edge runtimeAsyncLocalStorage for edge runtime
LauraBeatris
changed the title
AsyncLocalStorage for edge runtime
LauraBeatris
commented
Jul 4, 2024
| import { logger } from '@clerk/shared'; | ||
| import { handleValueOrFn } from '@clerk/shared/handleValueOrFn'; | ||
| import { isDevelopmentFromSecretKey } from '@clerk/shared/keys'; | ||
| import { logger } from '@clerk/shared/logger'; |
Member
Author
There was a problem hiding this comment.
This fixes the build warnings where MessageEvent was being imported during the edge runtime, since it was being resolved on the root of @clerk/shared.
LauraBeatris
commented
Jul 4, 2024
| @@ -1,3 +1,5 @@ | |||
| import { AsyncLocalStorage } from 'node:async_hooks'; | |||
Member
Author
There was a problem hiding this comment.
By using node:async_hooks, it uses the AsyncLocalStorage polyfill from Next.js. TBH it's a controversy from what Vercel docs mention, in which async_hooks would also be polyfilled: https://vercel.com/docs/functions/runtimes/edge-runtime#compatible-node.js-modules
LauraBeatris
force-pushed
the
fix/use-als-global
branch
from
23e238e to
00b7447
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3660
AsyncLocalStorageavailable as a global polyfill for the edge runtime, instead of importing from Node.js: https://nextjs.org/docs/pages/api-reference/edge#nextjs-specific-polyfillsloggerfrom nested importChecklist
npm testruns as expected.npm run buildruns as expected.Type of change