feat(clerk-js): Add dev mode notice to components by desiprisg · Pull Request #3511 · clerk/javascript

desiprisg · 2024-06-04T10:01:38Z

Description

Add a development mode notice to our components to avoid going to productions with dev keys by accident.

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-06-04T10:01:42Z

🦋 Changeset detected

Latest commit: 79dd3a9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages

Name	Type
@clerk/clerk-js	Minor
@clerk/types	Minor
@clerk/astro	Patch
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch
@clerk/backend	Patch
@clerk/elements	Patch
@clerk/express	Patch
@clerk/fastify	Patch
@clerk/localizations	Patch
@clerk/nextjs	Patch
@clerk/clerk-react	Patch
@clerk/remix	Patch
@clerk/clerk-sdk-node	Patch
@clerk/shared	Patch
@clerk/tanstack-start	Patch
@clerk/testing	Patch
@clerk/themes	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

desiprisg · 2024-06-04T10:01:54Z

!preview

clerk-cookie · 2024-06-04T10:07:04Z

Hey @octoper, your preview is available.

Status	Preview	Updated (UTC)
🍪 Deployed	Visit preview	Jul 31, 2024 10:09 AM

desiprisg · 2024-06-04T10:17:46Z

!preview

packages/clerk-js/src/ui/elements/DevModeNotice.tsx

packages/clerk-js/src/ui/elements/Card/CardContent.tsx

anagstef · 2024-06-05T16:29:08Z

@desiprisg can we have a screenshot of how this looks like?

desiprisg · 2024-06-05T18:03:21Z

@desiprisg can we have a screenshot of how this looks like?

Adding these! Feel free to check the preview deployment as well!

packages/clerk-js/src/ui/elements/Navbar.tsx

packages/clerk-js/src/ui/elements/PopoverCard.tsx

nikosdouvlis · 2024-06-10T11:31:24Z

Hey @desiprisg , whats the status of this one?

desiprisg · 2024-06-14T21:37:25Z

Hey @desiprisg , whats the status of this one?

We were waiting for user button / org switcher designs before merging this one.

octoper · 2024-06-26T11:40:08Z

!preview

nikosdouvlis · 2024-07-11T17:41:37Z

@octoper hey :) is this good to go? if not, do you need help with anything at this point?

octoper · 2024-07-11T17:43:36Z

There were no designs for <OrgSwitcher/> and <UserButton/> until yesterday, I will take a look at this today

octoper · 2024-07-12T00:24:08Z

!preview

nikosdouvlis · 2024-07-30T23:52:00Z

@PixelJanitor something's up with the GH comments, but here's your preview link: https://javascript-preview-3511.clerkpreview.com/

alexcarpenter · 2024-07-31T00:44:55Z

@nikosdouvlis @PixelJanitor needs to ensure his Clerk membership status is set to public for !preview and !snapshot comments to function https://github.com/clerk/javascript/blob/main/docs/PUBLISH.md#previewing-prs

nikosdouvlis · 2024-07-31T08:00:33Z

@alexcarpenter that's true, but the comment is missing even though the action I triggered was completed successfully: https://github.com/clerk/javascript/actions/runs/10171336607/job/28132106414

octoper · 2024-07-31T10:01:38Z

@nikosdouvlis @alexcarpenter The comment is only posted once and gets updated when !preview deployment is done, also the URL of the preview remains the same

octoper · 2024-07-31T10:01:51Z

!preview

.changeset/hungry-clouds-return.md

…ment mode notice

Co-authored-by: Stefanos Anagnostou <anagstef@users.noreply.github.com>

PixelJanitor

Not a code review approval from me (leaving that to an eng), but a design approval based on a deploy preview review. 👍

Co-authored-by: Vaggelis Yfantis <me@octoper.me> Co-authored-by: Stefanos Anagnostou <anagstef@users.noreply.github.com>

This reverts commit cf8bf65.

Co-authored-by: Vaggelis Yfantis <me@octoper.me> Co-authored-by: Stefanos Anagnostou <anagstef@users.noreply.github.com>

This reverts commit cf8bf65.

Co-authored-by: George Desipris <george.desipris.56@gmail.com> Co-authored-by: Stefanos Anagnostou <anagstef@users.noreply.github.com>

desiprisg requested review from PixelJanitor, anagstef, nikosdouvlis and panteliselef June 4, 2024 10:01

clerk-cookie added the clerk-js label Jun 4, 2024

desiprisg force-pushed the george/sdk-1805-update-aio-component-ui-to-be-more-obviously-in-dev-mode branch from d0c8cd0 to 2cbdac6 Compare June 4, 2024 10:03

desiprisg force-pushed the george/sdk-1805-update-aio-component-ui-to-be-more-obviously-in-dev-mode branch from 2cbdac6 to 8e9316d Compare June 4, 2024 10:17

PixelJanitor reviewed Jun 5, 2024

View reviewed changes

packages/clerk-js/src/ui/elements/DevModeNotice.tsx Outdated Show resolved Hide resolved

PixelJanitor reviewed Jun 5, 2024

View reviewed changes

packages/clerk-js/src/ui/elements/DevModeNotice.tsx Outdated Show resolved Hide resolved

PixelJanitor reviewed Jun 5, 2024

View reviewed changes

packages/clerk-js/src/ui/elements/Card/CardContent.tsx Outdated Show resolved Hide resolved

desiprisg force-pushed the george/sdk-1805-update-aio-component-ui-to-be-more-obviously-in-dev-mode branch 3 times, most recently from a6e46ac to 8f84fb9 Compare June 6, 2024 10:50

anagstef approved these changes Jun 6, 2024

View reviewed changes

packages/clerk-js/src/ui/elements/Navbar.tsx Show resolved Hide resolved

packages/clerk-js/src/ui/elements/PopoverCard.tsx Show resolved Hide resolved

octoper force-pushed the george/sdk-1805-update-aio-component-ui-to-be-more-obviously-in-dev-mode branch from 8f84fb9 to 5052798 Compare June 26, 2024 10:52

octoper force-pushed the george/sdk-1805-update-aio-component-ui-to-be-more-obviously-in-dev-mode branch from 5052798 to 17d5afa Compare July 1, 2024 19:02

octoper force-pushed the george/sdk-1805-update-aio-component-ui-to-be-more-obviously-in-dev-mode branch from 17d5afa to 9d79ddb Compare July 11, 2024 22:17

octoper self-assigned this Jul 12, 2024

clerk-cookie added the types label Jul 31, 2024

anagstef reviewed Jul 31, 2024

View reviewed changes

.changeset/hungry-clouds-return.md Outdated Show resolved Hide resolved

desiprisg and others added 11 commits July 31, 2024 16:34

feat(clerk-js): Add dev mode notice to components

2ec5137

feat(clerk-js): Update Development notice to match designs

4a2f63b

chore(clerk-js): Add dev notice to footer

7682753

fix(clerk-js): Remove missing prop from ClerkAndPagesTag

23548e9

chore(repo): Remove changes from playgrounf

1f75627

chore(repo): Revert change from webpack.config.js

b285473

fix(clerk-js): Apply Dev mopde notice better for all componentns

cea4ecb

chore(clerk-js): Added popoverBox descriptor and UI fixes for develop…

1d55b29

…ment mode notice

chore(repo): Update changeset

afb90c5

chore(repo): Update changeset

c5eece0

Update .changeset/hungry-clouds-return.md

79dd3a9

Co-authored-by: Stefanos Anagnostou <anagstef@users.noreply.github.com>

octoper force-pushed the george/sdk-1805-update-aio-component-ui-to-be-more-obviously-in-dev-mode branch from 8ce6b64 to 79dd3a9 Compare July 31, 2024 13:34

PixelJanitor approved these changes Jul 31, 2024

View reviewed changes

octoper merged commit cf8bf65 into main Jul 31, 2024

octoper deleted the george/sdk-1805-update-aio-component-ui-to-be-more-obviously-in-dev-mode branch July 31, 2024 15:32

clerk-cookie mentioned this pull request Jul 31, 2024

ci(repo): Version packages #3830

Merged

brkalow pushed a commit that referenced this pull request Aug 1, 2024

feat(clerk-js): Add dev mode notice to components (#3511)

e342dbc

Co-authored-by: Vaggelis Yfantis <me@octoper.me> Co-authored-by: Stefanos Anagnostou <anagstef@users.noreply.github.com>

nikosdouvlis added a commit that referenced this pull request Aug 1, 2024

Revert "feat(clerk-js): Add dev mode notice to components (#3511)"

3e15c08

This reverts commit cf8bf65.

octoper restored the george/sdk-1805-update-aio-component-ui-to-be-more-obviously-in-dev-mode branch August 1, 2024 08:48

octoper mentioned this pull request Aug 1, 2024

feat(clerk-js): Add dev mode warning to components (#3511) #3870

Merged

9 tasks

wobsoriano pushed a commit that referenced this pull request Aug 1, 2024

feat(clerk-js): Add dev mode notice to components (#3511)

518a18b

Co-authored-by: Vaggelis Yfantis <me@octoper.me> Co-authored-by: Stefanos Anagnostou <anagstef@users.noreply.github.com>

wobsoriano pushed a commit that referenced this pull request Aug 1, 2024

Revert "feat(clerk-js): Add dev mode notice to components (#3511)"

796cd57

This reverts commit cf8bf65.

octoper added a commit that referenced this pull request Aug 2, 2024

feat(clerk-js): Add dev mode warning to components (#3511) (#3870)

568186c

Co-authored-by: George Desipris <george.desipris.56@gmail.com> Co-authored-by: Stefanos Anagnostou <anagstef@users.noreply.github.com>

Conversation

desiprisg commented Jun 4, 2024 • edited by octoper Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Type of change

Uh oh!

changeset-bot bot commented Jun 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

desiprisg commented Jun 4, 2024

Uh oh!

clerk-cookie commented Jun 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

desiprisg commented Jun 4, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anagstef commented Jun 5, 2024

Uh oh!

desiprisg commented Jun 5, 2024

Uh oh!

Uh oh!

Uh oh!

nikosdouvlis commented Jun 10, 2024

Uh oh!

desiprisg commented Jun 14, 2024

Uh oh!

octoper commented Jun 26, 2024

Uh oh!

nikosdouvlis commented Jul 11, 2024

Uh oh!

octoper commented Jul 11, 2024

Uh oh!

octoper commented Jul 12, 2024

Uh oh!

nikosdouvlis commented Jul 30, 2024

Uh oh!

alexcarpenter commented Jul 31, 2024

Uh oh!

nikosdouvlis commented Jul 31, 2024

Uh oh!

octoper commented Jul 31, 2024

Uh oh!

octoper commented Jul 31, 2024

Uh oh!

Uh oh!

PixelJanitor left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

desiprisg commented Jun 4, 2024 •

edited by octoper

Loading

changeset-bot bot commented Jun 4, 2024 •

edited

Loading

clerk-cookie commented Jun 4, 2024 •

edited

Loading