Skip to content

Updated tide module and Jupyter notebook!#3

Closed
socoyjonathan wants to merge 15 commits intoclawpack:mainfrom
socoyjonathan:main
Closed

Updated tide module and Jupyter notebook!#3
socoyjonathan wants to merge 15 commits intoclawpack:mainfrom
socoyjonathan:main

Conversation

@socoyjonathan
Copy link
Contributor

No description provided.

@rjleveque
Copy link
Member

It looks like the tide.py file in this PR is almost identical to the one in clawpack/geoclaw#532, should that just be used instead?

Currently the Tide_Module_Examples.ipynb notebook imports tide at the top but then also has
import clawpack.geoclaw.tide as tide
later on in the notebook, so it's using both versions.

@mandli
Copy link
Member

mandli commented Mar 1, 2022

Yes.

@socoyjonathan
Copy link
Contributor Author

Updated jupyter notebook and deleted local tide.py to avoid issues.

@rjleveque rjleveque mentioned this pull request Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants