Closed
Conversation
Owner
|
tried it out and it works like a charm. Would you mind adding the instructions to the README? We might be due for a slight overhaul there soon to make the different setup paths clearer, but just having a little header with the basic Docker info (which I appreciate is pretty much just standard basic-Docker-setup steps) will ensure that if we refactor that that it gets included. and thanks so much for the contributions! |
ckolderup
requested changes
May 6, 2025
Owner
ckolderup
left a comment
There was a problem hiding this comment.
verified with a local setup and with a small README update, this will be ready to ship quickly.
Contributor
Author
|
Sorry, I broke the pull request by cleaning up my repo. I think I have to create a new pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added two files to start the postmarks server inside of a docker container. Using the
Dockerfileyou can build the image like this:docker build -t postmarks .Or you can use
docker-composeinstead and start the server withdocker compose up -d. The configuration is still read from.envandaccount.json. The persistent data is still stored in.data.