update Dockerfile and devcontainer configuration #4773
+39
−151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lum1n0us
requested review from
TianlongLiang,
loganek,
no1wudi and
yamt
as code owners
…etup and package management The goal is to keep the devcontainer image minimal and its build time as fast as possible. - Remove all rarely used tools. - Change the base image to the latest template. - Synchronize the WASI-SDK and WABT versions with those used by the CI.
lum1n0us
force-pushed
the
enh/update_devcontainer
branch
from
2c90088 to
46822b8
Compare
TianlongLiang
approved these changes
Jan 7, 2026
Contributor
TianlongLiang
left a comment
TianlongLiang
left a comment
There was a problem hiding this comment.
LGTM with a minor comment
|
|
||
| # | ||
| # install wasi-sdk | ||
| ARG WASI_SDK_VER=20 |
Contributor
There was a problem hiding this comment.
should we use matain the consistent version between Dockerfile and devcontainer.json for WASI SDK and WABT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to keep the devcontainer image minimal and its build time as fast as possible.