Don't expose absolute paths to source files#205
Merged
tschneidereit merged 1 commit intobytecodealliance:mainfrom Mar 20, 2025
Merged
Don't expose absolute paths to source files#205tschneidereit merged 1 commit intobytecodealliance:mainfrom
tschneidereit merged 1 commit intobytecodealliance:mainfrom
Conversation
Member
Author
|
(Note that this is based on #202, so only the last commit needs review here.) |
guybedford
approved these changes
Mar 19, 2025
This changes componentization to make paths relative to the current working directory. E.g. when componentizing `[project dir]/src/index.js`, instead of seeing that full path, content will now see `src/index.js`, because we preopen `[project dir]` as `/` and can thus treat all paths as relative to that. This only works for Wizer, since Weval doesn't have a way to map directories in this way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes componentization to make paths relative to the current working directory. E.g. when componentizing
[project dir]/src/index.js, instead of seeing that full path, content will now seesrc/index.js, because we preopen[project dir]as/and can thus treat all paths as relative to that.This only works for Wizer, since Weval doesn't have a way to map directories in this way.