Report parent module filename in "Error: Cannot find module" output#64
Report parent module filename in "Error: Cannot find module" output#64jmm wants to merge 4 commits intobrowserify:masterfrom
Conversation
|
Really useful to have this. Browserify "cannot find module from" error really needs this info! |
|
Made a plugin for this: https://www.npmjs.com/package/browserify-require-not-found-parent |
|
Any chance that this PR gets merged? |
|
@jmm would you mind rebasing this and rerunning tests? (or checking the "allow maintainers to edit" checkbox) |
|
@tcchau one of the two options in #64 (comment) would be ideal, so that we don't need to open a new PR. |
|
@tcchau if you are still interested in tackling this, opening a new PR would be great :) |
|
Hi @goto-bus-stop I will see if I can find that repo again. I've since stopped using browserify and moved on to webpack, but I'm happy to issue the PR. I need to figure what this issue was, then probably rebase with the latest and then submit. Stay tuned I guess! |
|
Hi @goto-bus-stop, I've submitted a PR #161 |
Fix #60.
There were several tests in
test/resolver.jsfor theCannot find moduleerror and I added new tests at a couple of those locations. It didn't seem like there'd be any additional value to add new tests at the other locations -- do you agree?The next step toward exposing this in browserify will be getting browser-resolve to bump the resolve version.