Add appveyor and travis CI configuration files for future pull requests#30
Closed
jeking3 wants to merge 1 commit intoboostorg:developfrom
Closed
Add appveyor and travis CI configuration files for future pull requests#30jeking3 wants to merge 1 commit intoboostorg:developfrom
jeking3 wants to merge 1 commit intoboostorg:developfrom
Conversation
jeking3
force-pushed
the
ci
branch
5 times, most recently
from
b71a0a9 to
b6e5115
Compare
Contributor
Author
|
@swatanabe this is ready to merge, and following that if you need any assistance getting the builds running for PRs in the boostorg account, let me know. I may put a document together on it. |
Contributor
Author
|
@swatanabe anything else you need me to do in order to get this merged? |
Contributor
Author
|
This can evolve to codecov.io support, check out the cool integration they have: |
Contributor
Author
|
@swatanabe anything else you need me to do in order to get this merged? |
Collaborator
|
AMDG
On 12/05/2017 08:44 AM, James E. King, III wrote:
@swatanabe anything else you need me to do in order to get this merged?
There have been some concerns about resource
limits recently. Since I don't actually use this,
I'm not sure that it's worthwhile.
In Christ,
Steven Watanabe
|
Contributor
Author
|
I'm confused - you don't want to enable folks submitting pull requests into Boost.Random to be able to self-verify their changes are somewhat decent before a code review? These changes are not just for you, but also to help folks submit higher quality code on their own. |
jeking3
force-pushed
the
ci
branch
2 times, most recently
from
4359256 to
702d280
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Results
Appveyor: https://ci.appveyor.com/project/jeking3/random/build/1.0.18-develop
Travis: https://travis-ci.org/jeking3/random/builds/286190652
Known Issues
The following builds are commented out because of issues in this or other modules:
These should be investigated, fixed, and tests re-enabled.
Maintainer Follow-Up
To activate these changes, the maintainer of Boost.Random would need to request admin access on github, travis, and appveyor so that they can enable automatic builds on pull requests to the official repository.
I would also recommend a README.md should also be added similar to Boost.Uuid that allows for inspection of the current build status of master and develop branches.