Closed
Conversation
# Fixed Deprecated Copy Constructor Warning in `polynomial.hpp` ## Issue Description The `boost/random/detail/polynomial.hpp` triggers compiler warnings related to a deprecated implicit copy constructor: ``` warning: definition of implicit copy constructor for 'reference' is deprecated because it has a user-declared copy assignment operator [-Wdeprecated-copy] ``` This warning occurs in C++11 and later standards when a class has a user-declared copy assignment operator but no user-declared copy constructor. ## Cause The `reference` class has a user-declared copy assignment operator: ```cpp reference &operator=(const reference &other) ``` However, this reference class lacks an explicitly declared copy constructor. ## Nature of the Fix The fix explicitly declares both a copy constructor and a move constructor for `reference`, adding the following lines: ```cpp reference(const reference& other) = default; reference(reference&& other) = default; ``` When declaring these constructors as `default`, the compiler to generates default implementations, thus: 1. Silencing the deprecation warning for the implicit copy constructor. 2. Maintaining the existing behavior of the `reference` class. 3. Ensuring that the class can still be copied and moved as before, preserving its functionality. ## Impact of the Fix This fix resolves the compiler warnings without changing the functionality of the `reference` class. The fix is backwards-compatible and should not introduce any behavioral changes in existing code. ## Conclusion This update brings the `polynomial.hpp` file in line with current C++ standards and best practices. It eliminates deprecation warnings while maintaining existing functionality.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #110 +/- ##
========================================
Coverage 94.84% 94.84%
========================================
Files 101 101
Lines 6242 6242
========================================
Hits 5920 5920
Misses 322 322
Continue to review full report in Codecov by Sentry.
|
Author
|
Many checks were not successful, so I'm going to close this pull request and make another with extended compiler backwards compatibility. I'll note the forwards-compatible fix in my next attempt. |
Member
|
I believe this fix is correct. The issues that I see in the CI are coming from 1) Github breaking the Node version in Actions, and 2) The boost.math dependency makes it so this library needs to be built now from C++14 and not from C++11. I'll fix up the CI system. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed Deprecated Copy Constructor Warning in
polynomial.hppIssue Description
The
boost/random/detail/polynomial.hpptriggers compiler warnings related to a deprecated implicit copy constructor:This warning occurs in C++11 and later standards when a class has a user-declared copy assignment operator but no user-declared copy constructor.
Cause
The
referenceclass has a user-declared copy assignment operator:However, this reference class lacks an explicitly declared copy constructor.
Nature of the Fix
The fix explicitly declares both a copy constructor and a move constructor for
reference, adding the following lines:When declaring these constructors as
default, the compiler generates default implementations, thus:referenceclass.Impact of the Fix
This fix resolves the compiler warnings without changing the functionality of the
referenceclass.The fix is backwards-compatible and should not introduce any behavioral changes in existing code.
Conclusion
This update brings the
polynomial.hppfile in line with current C++ standards and best practices. It eliminates deprecation warnings while maintaining existing functionality.