cuda_specs.py: fix version tag string for ROCm/CUDA library lookup#1889
Merged
matthewdouglas merged 1 commit intobitsandbytes-foundation:mainfrom Mar 9, 2026
Merged
cuda_specs.py: fix version tag string for ROCm/CUDA library lookup#1889matthewdouglas merged 1 commit intobitsandbytes-foundation:mainfrom
matthewdouglas merged 1 commit intobitsandbytes-foundation:mainfrom
Conversation
…82"; CUDA breaks when minor > 9) with simple string concatenation, producing the expected tags:
- ROCm 7.12 → "712"
- CUDA 12.4 → "124"
This makes version tag derivation consistent across CUDA and ROCm and fixes ROCm shared library name resolution (e.g. libbitsandbytes_rocm712.so).
We should not use zero-padding (e.g. `{minor:02d}`), as that would change CUDA tags (e.g. 12.4 → "1204") .
This was referenced Mar 6, 2026
matthewdouglas
added
ROCm
CUDA
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced the incorrect
major * 10 + minorlogic (e.g. ROCm 7.12 → "82"; CUDA breaks when minor > 9) with simple string concatenation, producing the expected tags:This makes version tag derivation consistent across CUDA and ROCm and fixes ROCm shared library name resolution (e.g. libbitsandbytes_rocm712.so). We should not use zero-padding (e.g.
{minor:02d}), as that would change CUDA tags (e.g. 12.4 → "1204") .Hope this helps.