Open
Conversation
- create autoconfiguration for each client or server module, without componentscan - move integration tests to a subpackage to avoid autowiring problems with the problem modules
- add missing @bean annotations - move error and exception handlers to common spring module
- add WebClientFilter - add an interface ProblemResponseErrorHandler
- reference ProblemResponseErrorHandler interface where possible
Contributor
Author
|
@jpraet , could you review if the changes in the PR look good to you high-level? I've tested it locally in a Spring (non-Boot) project using the |
Contributor
Looks good to me high-level. Thank you |
…spring boot functionality and have very little code
Contributor
Author
|
The PR is now ready for review. I made following changes, on top of the previous ones:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Lots of refactoring to enable support for Spring without Spring Boot dependencies.
@Configuration(application contexts) insteadWebClientFilterextractingPROBLEM_FILTERfromAbstractProblemWebClientCustomizerProblemResponseErrorHandler@EnableProblemModule(beanValidation=true, swaggerRequestValidation=false, ...)to enable easy activation in non SB-environmentOther:
RoutingExceptionHandler(the split was bcNoResourceFoundExceptionwas new in SBv3)@Valueinstead of@ConfigurationPropertiesto cut dependency to spring bootTODO:
EnableProblemModuleintellij shows issues that beans aren't found, while tests doe work