First index type T is not required #8
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcherny
requested changes
Jan 2, 2021
Owner
bcherny
left a comment
bcherny
left a comment
There was a problem hiding this comment.
Hey, thank you for the contribution!
Unfortunately, this isn't quite right. If you type ...b as a tuple -- and not as a tuple with at least one element -- TypeScript won't complain when you try and call is with a single argument:
is('x') // Ok, should be an errorBy requiring ...b to have a length of >=1, TypeScript makes sure that is is called with at least two arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.