Skip to content

fix(GPHedge): replace list with sequence #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
till-m merged 1 commit into from
Sep 30, 2024
Merged

fix(GPHedge): replace list with sequence #524

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions bayes_opt/acquisition.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
from bayes_opt.target_space import TargetSpace

if TYPE_CHECKING:
from collections.abc import Callable
from collections.abc import Callable, Sequence

from numpy.typing import NDArray
from scipy.optimize import OptimizeResult
Expand Down Expand Up @@ -912,18 +912,18 @@ class GPHedge(AcquisitionFunction):

Parameters
----------
base_acquisitions : List[AcquisitionFunction]
List of base acquisition functions.
base_acquisitions : Sequence[AcquisitionFunction]
Sequence of base acquisition functions.

random_state : int, RandomState, default None
Set the random state for reproducibility.
"""

def __init__(
self, base_acquisitions: list[AcquisitionFunction], random_state: int | RandomState | None = None
self, base_acquisitions: Sequence[AcquisitionFunction], random_state: int | RandomState | None = None
) -> None:
super().__init__(random_state)
self.base_acquisitions = base_acquisitions
self.base_acquisitions = list(base_acquisitions)
self.n_acq = len(self.base_acquisitions)
self.gains = np.zeros(self.n_acq)
self.previous_candidates = None
Expand Down