fix: Incorrectly modified ScreenLogger#512
Merged
till-m merged 4 commits intobayesian-optimization:masterfrom Sep 7, 2024
Merged
fix: Incorrectly modified ScreenLogger#512till-m merged 4 commits intobayesian-optimization:masterfrom
ScreenLogger#512till-m merged 4 commits intobayesian-optimization:masterfrom
Conversation
phi-friday
changed the title
ScreenLoggerScreenLogger
till-m
approved these changes
Aug 8, 2024
Member
till-m
left a comment
till-m
left a comment
There was a problem hiding this comment.
Thanks, good fix. I was just wondering about this.
Will merge after the docs change.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before I applied #497 it worked like this
BayesianOptimization/bayes_opt/logger.py
Line 167 in bc9af23
but after,
BayesianOptimization/bayes_opt/logger.py
Line 164 in 16c00f3
I expect it to work the same as before.