Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2 #189 +/- ##
============================================
+ Coverage 90.90% 91.83% +0.92%
- Complexity 90 97 +7
============================================
Files 6 6
Lines 231 245 +14
Branches 24 26 +2
============================================
+ Hits 210 225 +15
Misses 18 18
+ Partials 3 2 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ThirdEyeSqueegee
previously approved these changes
Mar 4, 2026
simonmarty
requested changes
Mar 4, 2026
- Add validation to prevent conflicting configuration (custom client + PQTLS flag) - Throw IllegalArgumentException when both settings are provided - Add @SuppressFBWarnings annotations to suppress CT_CONSTRUCTOR_THROW warnings - Validation occurs before field initialization, making it safe - Update test to verify exception is thrown for invalid configuration
simonmarty
reviewed
Mar 10, 2026
src/main/java/com/amazonaws/secretsmanager/caching/SecretCacheConfiguration.java
Show resolved
Hide resolved
simonmarty
reviewed
Mar 11, 2026
src/main/java/com/amazonaws/secretsmanager/caching/SecretCache.java
Outdated
Show resolved
Hide resolved
simonmarty
approved these changes
Mar 11, 2026
ThirdEyeSqueegee
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Add Post-Quantum TLS support to AWS Secrets Manager Java caching client. Adds configuration option
withPostQuantumTlsEnabled()that uses AWS CRT HTTP client with PQTLS enabled.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.