fix(submit) - pip build on windows command causing unintended consequence on posix#236
Merged
mmaeng merged 4 commits intoaws-cloudformation:masterfrom Jan 6, 2023
Merged
Conversation
added 4 commits
December 19, 2022 13:33
…g pip build to not include requirements on posix
kddejong
approved these changes
Jan 3, 2023
ericzbeard
approved these changes
Jan 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #235
Non docker - python requirements build on Windows requires shell parameter for subprocess.run. This causes non-docker builds on POSIX systems to not gather dependencies. Changed to use altered statement only on windows.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.