switch auto_remove with remove in codegen and tests#221
Merged
mircealam merged 1 commit intoaws-cloudformation:masterfrom Oct 9, 2023
Merged
switch auto_remove with remove in codegen and tests#221mircealam merged 1 commit intoaws-cloudformation:masterfrom
mircealam merged 1 commit intoaws-cloudformation:masterfrom
Conversation
There was a problem hiding this comment.
I have a suggestion to also help with debugging (this change is great by the way, it really helped me out). In python/rpdk/python/codegen.py just below your change there is a section that catches the ContainerError... I suggest you add an error log line that dumps out stderr. That way they will see what error was produced.
except (ContainerError, ImageLoadError, APIError) as e:
LOG.error(e.stderr)
raise DownstreamError("Error running docker build") from e
Nevermind that suggestion, I can see that it winds up printing the same information twice which is silly. So please ignore this...
Contributor
Author
|
@aservedio-swi Thanks for the feedback! Glad the update was of help! There is more discussion on the core of this change in #214 |
kddejong
approved these changes
Mar 8, 2023
mircealam
approved these changes
Oct 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #211
Use docker container.run remove option instead of auto_remove. If the job errors, this will allow the user to run the container outside the run and troubleshoot further. This will also mean on error manual cleanup of the containers would be necessary.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.