Log Formatter#190
Merged
Brianwithay21 merged 5 commits intoaws-cloudformation:masterfrom Sep 13, 2022
Merged
Conversation
ammokhov
approved these changes
Jul 22, 2022
Brianwithay21
approved these changes
Jul 28, 2022
Member
Brianwithay21
left a comment
Brianwithay21
left a comment
There was a problem hiding this comment.
Changes look good to me for Hook types
Contributor
Author
|
I'm not authorized to merge. Just wanted to check that this is in flight. |
Contributor
Author
|
Bueller? |
Member
|
apologies for the delay. Your change has been merged. Thank you for contributing |
Contributor
Author
|
No worries, appreciate you guys taking a look. |
kddejong
pushed a commit
to kddejong/cloudformation-cli-python-plugin
that referenced
this pull request
Oct 13, 2022
* add log_format argument * move set format condition * test test * add tests * lint pass
kddejong
pushed a commit
to kddejong/cloudformation-cli-python-plugin
that referenced
this pull request
Oct 13, 2022
* add log_format argument * move set format condition * test test * add tests * lint pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #189
Description of changes: Adds optional argument to Hook to establish log formatter for handler.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.