Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

File diff selection mode improvements #469

@kuychaco

Description

@kuychaco

Selection mode determines the behavior when selecting multiple lines/hunks.

Better indication

Say all hunk lines in a given hunk are selected. Right now the UI does not clearly indicate whether the selection mode is line or hunk. Thus if you shift-click and hit the down key, it's unclear whether the next hunk or line will be selected.

@BinaryMuse suggested that we change the background color of selected hunks when in hunk selection mode. Perhaps we could also change the background color of the the context lines in the hunk.

Entering modes

  • Single clicking a line enters line mode
  • Single clicking a hunk header or double-clicking a line in a hunk enters hunk mode
  • github:toggle-patch-selection-mode or / switches from one mode to another

Versions

Atom Version (atom --version):

GitHub Package Version (git --git-dir ~/.atom/packages/github/.git rev-parse head): 65a2403

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions