Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds Editor support for native dialogs by introducing a dedicated DialogEditor implementation, enriching public APIs with XML documentation, and updating DialogManager to route dialog calls through the new editor handler.
- Added XML doc comments on interfaces and classes for clarity.
- Introduced
DialogEditorfor Unity Editor dialog support and wired it intoDialogManager. - Updated
DialogManagerpublic API (labels, show/dismiss methods) and fixed lifecycle region typo.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Packages/com.github.asus4.nativedialog/Runtime/Internal/IDialogReceiver.cs | Added summary docs to the dialog-receiver interface. |
| Packages/com.github.asus4.nativedialog/Runtime/Internal/IDialog.cs | Added summary docs to the platform-dialog interface. |
| Packages/com.github.asus4.nativedialog/Runtime/Internal/DialogMock.cs | Added doc comments to the mock dialog class (now unused). |
| Packages/com.github.asus4.nativedialog/Runtime/Internal/DialogIOS.cs | Added summary docs to the iOS dialog implementation. |
| Packages/com.github.asus4.nativedialog/Runtime/Internal/DialogAndroid.cs | Added summary docs to the Android dialog implementation. |
| Packages/com.github.asus4.nativedialog/Runtime/Internal/DialogEditor.cs | New Editor-based dialog implementation for Unity Editor mode. |
| Packages/com.github.asus4.nativedialog/Runtime/Internal/DialogEditor.cs.meta | Metadata for the new DialogEditor asset. |
| Packages/com.github.asus4.nativedialog/Runtime/DialogManager.cs | Switched Editor support to DialogEditor, added XML docs to public methods, corrected region typo. |
| Assets/NativeDialogSample.cs | Added XML docs to sample usage component. |
Comments suppressed due to low confidence (2)
Packages/com.github.asus4.nativedialog/Runtime/Internal/IDialogReceiver.cs:7
- DialogEditor calls
receiver?.OnCancel(...)butIDialogReceiveronly definesOnSubmit. Add anOnCancel(string idStr)method to the interface to match its use.
internal interface IDialogReceiver
Packages/com.github.asus4.nativedialog/Runtime/Internal/DialogMock.cs:10
DialogMockis no longer instantiated byDialogManager(Editor now usesDialogEditor). Consider removingDialogMockor restoring its intended use to avoid dead code.
internal sealed class DialogMock : MonoBehaviour, IDialog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.