Skip to content

Update messenger.mex for ubuntu.#219

Merged
isbadawi merged 1 commit intoarokem:masterfrom
isbadawi:fix-travis
Sep 18, 2015
Merged

Update messenger.mex for ubuntu.#219
isbadawi merged 1 commit intoarokem:masterfrom
isbadawi:fix-travis

Conversation

@isbadawi
Copy link
Collaborator

Compiled against latest octave. Should hopefully fix the Travis build.

@isbadawi
Copy link
Collaborator Author

Seems I compiled against the wrong version of zmq. I'll try this again...

Compiled against latest octave.
@isbadawi
Copy link
Collaborator Author

Third time's the charm...

This fixes the octave failure, now there is an error about import IPython.nbformat.v4 as nbformat which I guess is what #213 is trying to fix. I'll merge this one.

This is good for the travis build, but I'm not sure what the right thing to do is here for users. Do we need different versions of messenger.mex for different octave versions, as well as different zmq versions?

isbadawi added a commit that referenced this pull request Sep 18, 2015
Update messenger.mex for ubuntu.
@isbadawi isbadawi merged commit 641d5e7 into arokem:master Sep 18, 2015
@arokem
Copy link
Owner

arokem commented Sep 18, 2015

Thanks so much for jumping in with this @isbadawi! And apologies for being AWOL last few weeks.

@arokem
Copy link
Owner

arokem commented Sep 18, 2015

Concerning the generally right thing to do: I think that we should go with support for recent versions of Octave and zmq. It's a stretch to support every possible combination. I have had trouble compiling the messenger against newer octave on my mac so far, but will keep trying...

@arokem arokem mentioned this pull request Sep 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants