Use npm published resolution#239
Conversation
andrewbranch
left a comment
There was a problem hiding this comment.
This is great! I was surprised something like this didn’t already exist when I started the project. Thank you! Can you add a changeset?
|
Where is the changesets integration, I wonder? 🤔 |
🦋 Changeset detectedLatest commit: f118862 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thanks for the suggestion. I've never used this workflow so it took some research but it seems handy because people have complained in the past that I don't maintain changelogs. I got that set up in the monorepo and backfilled the changelogs. Also, included one for this PR. I was also surprised that nothing like this existed. Based on the prevalence of "bundler" resolvers I think developers tend to want something that just infers what they want instead of explicitly declaring their intention. Your project is unique in that regard: pedantry is the whole point. |
|
Cool! Sorry, I was only asking for you to include one in this PR 😄 That said, I think you’ll like having it set up purely for the automatic publishing and version bumping. This repo was the first place I’ve used it and I’m a big fan. |
I published my implementations of the resolution algorithms to a new npm package. I'm not sure if you'd prefer to keep the one in this repository, though. I'm using the npm package in my import.meta.url-preserving TypeScript loader. My team is using this loader internally, so I have a vested interest in keeping it up to date.
I did find a handful of errors in the specification: nodejs/node#57080, and a few other bugs in my implementation. It doesn't look it affected any packages in your test suite.