Revert "feat: migrate analytics from Cloudflare Worker to SvelteKit hooks"#2819
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (19)
WalkthroughThis PR removes the server-side Profound Analytics SvelteKit integration and replaces it with a Cloudflare Workers edge handler. Environment variables for PROFOUND_API_URL and PROFOUND_API_KEY are removed from .env.example and CI workflows. A new log-collector directory is introduced with TypeScript configuration, Wrangler settings, and a worker implementation that forwards request/response logging to an external API. Prerender configurations are added or adjusted across multiple routes. The .prettierignore is updated to stop ignoring generated files. Minor package.json script modifications change the runtime for one task and add reinstall-after-cleanup behavior. Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR reverts #2809, moving Profound Analytics collection back from a SvelteKit server hook ( Key changes:
Confidence Score: 5/5
Important Files Changed
Last reviewed commit: "Revert "feat: migrat..." |
| } | ||
|
|
||
| export const GET: RequestHandler = () => { | ||
| export const GET: RequestHandler = ({ request }) => { |
There was a problem hiding this comment.
The { request } destructuring was added in this revert, but request is never referenced anywhere in the function body. Since this endpoint also has export const prerender = true (line 4), the handler is invoked with a mock request during build time anyway, making this even less useful. The parameter should be removed to avoid confusion.
| export const GET: RequestHandler = ({ request }) => { | |
| export const GET: RequestHandler = () => { |
Reverts #2809
Summary by CodeRabbit
Release Notes
Features Removed
New Features
Configuration & Build Updates