Add .spec.service.disableTopologyRouting to clear topology annotations#750
Merged
Add .spec.service.disableTopologyRouting to clear topology annotations#750
Conversation
leochr
reviewed
Mar 2, 2026
api/v1/runtimecomponent_types.go
Outdated
| SessionAffinity *RuntimeComponentServiceSessionAffinity `json:"sessionAffinity,omitempty"` | ||
|
|
||
| // Disables topology routing annotations from being added to the Service. Defaults to false. | ||
| // +operator-sdk:csv:customresourcedefinitions:order=20,type=spec,displayName="Disable Topology",xDescriptors="urn:alm:descriptor:com.tectonic.ui:booleanSwitch" |
Member
There was a problem hiding this comment.
Update displayName: Disable Topology --> Disable Topology Routing
Suggestion: Disable topology aware routing annotations from being added to the Service. Defaults to false.
Collaborator
Author
There was a problem hiding this comment.
Thanks, added a commit to address this
kabicin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?:
.spec.service.disableTopologyboolean. When set to true it clears topology annotations on theService. Topology annotations are enabled by default.service.kubernetes.io/topology-aware-hintsand usesservice.kubernetes.io/topology-modeonly.Does this PR introduce a user-facing change?
CHANGELOG.mdWhich issue(s) this PR fixes:
Fixes #