Skip to content

Update fullstack tutorial to use Apollo Server 3#238

Merged
StephenBarlow merged 3 commits intomasterfrom
sb/as3
Aug 26, 2021
Merged

Update fullstack tutorial to use Apollo Server 3#238
StephenBarlow merged 3 commits intomasterfrom
sb/as3

Conversation

@StephenBarlow
Copy link
Contributor

No description provided.

@StephenBarlow StephenBarlow requested a review from glasser August 24, 2021 21:19
Copy link
Member

@glasser glasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some missing changes in index.js (they would be errors if this were in TypeScript... maybe it should be :) )

  • remove playground: true
  • i don't really understand what the heck "internalEngineDemo" is. What do we need that for? But it should be changed to not have the word "engine" in it (or remove it?), and it should have a graphVariant field instead of schemaTag (though current is also the default so 🤷 ). And honestly, the generateClientInfo there looks weird too — it's looking for old header names that don't start with apollographql-. So unless the tutorials ask you to set exactly those headers, just remove this whole file? I suspect this is so old that it predates client info being gathered by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants