Update fullstack tutorial to use Apollo Server 3#238
Merged
StephenBarlow merged 3 commits intomasterfrom Aug 26, 2021
Merged
Conversation
glasser
requested changes
Aug 24, 2021
Member
glasser
left a comment
There was a problem hiding this comment.
There are some missing changes in index.js (they would be errors if this were in TypeScript... maybe it should be :) )
- remove
playground: true - i don't really understand what the heck "internalEngineDemo" is. What do we need that for? But it should be changed to not have the word "engine" in it (or remove it?), and it should have a graphVariant field instead of schemaTag (though
currentis also the default so 🤷 ). And honestly, the generateClientInfo there looks weird too — it's looking for old header names that don't start withapollographql-. So unless the tutorials ask you to set exactly those headers, just remove this whole file? I suspect this is so old that it predates client info being gathered by default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.