Skip to content

Comments

fix loginVariables as LoginVariables#202

Closed
r0y0u wants to merge 1 commit intoapollographql:masterfrom
r0y0u:master
Closed

fix loginVariables as LoginVariables#202
r0y0u wants to merge 1 commit intoapollographql:masterfrom
r0y0u:master

Conversation

@r0y0u
Copy link

@r0y0u r0y0u commented Feb 22, 2021

Fix Issue #197

LoginTypes.loginVariables is changed as LoginTypes.LoginVariables.

Before Fix

When running cd final/client && npm i && npm start, it shows the error message below.

Failed to compile.

/fullstack-tutorial/final/client/src/components/login-form.tsx
TypeScript error in /fullstack-tutorial/final/client/src/components/login-form.tsx(14,38):
Namespace '"/fullstack-tutorial/final/client/src/pages/__generated__/login"' has no exported member 'loginVariables'.  TS2694

    12 | 
    13 | interface LoginFormProps {
  > 14 |   login: (a: { variables: LoginTypes.loginVariables }) => void;
       |                                      ^
    15 | }
    16 | 
    17 | interface LoginFormState {

After Fix

The client script is complied successfully when running cd final/client && npm i && npm start.

Compiled successfully!

You can now view client in the browser.

  Local:            http://localhost:3000
  On Your Network:  http://192.168.1.35:3000

Note that the development build is not optimized.
To create a production build, use npm run build.

@apollo-cla
Copy link

@weiy6: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Copy link

@wilo087 wilo087 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested and works property

@weiliang903
Copy link

@apollo-cla @r0y0u
The same error, why half a year has passed and still not merged

@StephenBarlow
Copy link
Contributor

Thanks for the PR and sorry for the delay! This fix has been merged separately via #237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants