Open
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new “Sklearn Testing” operator that computes common evaluation metrics on a collected dataset using a provided scikit-learn model.
- Introduces
SklearnTestingOpDescwith Python code generation for accuracy, F1, precision, and recall. - Registers the new operator in the logical operator registry.
- Extends the output schema to include the computed metric fields.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| core/workflow-operator/src/main/scala/edu/uci/ics/amber/operator/sklearn/testing/SklearnTestingOpDesc.scala | New operator descriptor for Sklearn testing with codegen and schema updates |
| core/workflow-operator/src/main/scala/edu/uci/ics/amber/operator/LogicalOp.scala | Added registration of the Sklearn Testing operator |
Comments suppressed due to low confidence (1)
core/workflow-operator/src/main/scala/edu/uci/ics/amber/operator/sklearn/testing/SklearnTestingOpDesc.scala:33
- This new operator does not appear to have any associated unit or integration tests; adding test coverage for typical and edge-case scenarios would help ensure correctness.
class SklearnTestingOpDesc extends PythonOperatorDescriptor {
...perator/src/main/scala/edu/uci/ics/amber/operator/sklearn/testing/SklearnTestingOpDesc.scala
Outdated
Show resolved
Hide resolved
...perator/src/main/scala/edu/uci/ics/amber/operator/sklearn/testing/SklearnTestingOpDesc.scala
Outdated
Show resolved
Hide resolved
Yicong-Huang
requested changes
Jul 8, 2025
Contributor
Yicong-Huang
left a comment
There was a problem hiding this comment.
This operator's design can be further discussed.
...perator/src/main/scala/edu/uci/ics/amber/operator/sklearn/testing/SklearnTestingOpDesc.scala
Show resolved
Hide resolved
...perator/src/main/scala/edu/uci/ics/amber/operator/sklearn/testing/SklearnTestingOpDesc.scala
Show resolved
Hide resolved
...perator/src/main/scala/edu/uci/ics/amber/operator/sklearn/testing/SklearnTestingOpDesc.scala
Show resolved
Hide resolved
...perator/src/main/scala/edu/uci/ics/amber/operator/sklearn/testing/SklearnTestingOpDesc.scala
Show resolved
Hide resolved
...perator/src/main/scala/edu/uci/ics/amber/operator/sklearn/testing/SklearnTestingOpDesc.scala
Show resolved
Hide resolved
Contributor
Author
|
Had offline discussions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce the Sklearn Testing Operator, which accepts any number of machine learning models (from 1 to n) and computes
accuracy,F1score,precision, andrecallfor each model, appending these metrics to the output columns.There is a port dependency between the model and the data: the data port must be finished first. The data table is then used as an internal state for testing. This operator can accept any number of models; each model will be tested against the same data table.
Input single model:

Input multiple models:
