Skip to content

Pin Docker GitHub Actions to Apache approved SHAs#13753

Merged
wu-sheng merged 2 commits intomasterfrom
fix/pin-docker-actions-to-approved-shas
Mar 22, 2026
Merged

Pin Docker GitHub Actions to Apache approved SHAs#13753
wu-sheng merged 2 commits intomasterfrom
fix/pin-docker-actions-to-approved-shas

Conversation

@wu-sheng
Copy link
Member

Fix Docker actions blocked by Apache enterprise action allow list

Apache enforces an allow list for third-party GitHub Actions via infrastructure-actions/approved_patterns.yml. Docker actions using version tags (e.g., @v3) are not on the list and will be blocked.

This PR pins all Docker actions to the approved SHA commits:

Action Before After (approved SHA)
docker/login-action @v3 / @v1.10.0 @c94ce9fb468520275223c153574b00df6fe4bcc9
docker/setup-buildx-action @v3 @8d2750c68a42422c14e847fe6c8ac0403b4cbd6f
docker/setup-qemu-action @v3 @29109295f81e9208d7d86ff1c6c12d2833863392
  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

Replace version tags with SHA pins from Apache infrastructure-actions
approved_patterns.yml to comply with the enterprise action allow list.

- docker/login-action: v3/v1.10.0 → c94ce9fb...
- docker/setup-buildx-action: v3 → 8d2750c6...
- docker/setup-qemu-action: v3 → 29109295...
@wu-sheng wu-sheng requested a review from kezhenxu94 March 21, 2026 14:28
@wu-sheng wu-sheng added CI settings CI settings adjustment AI Assistant Claude and other AI Coding Tooling labels Mar 21, 2026
@wu-sheng wu-sheng added this to the 10.4.0 milestone Mar 21, 2026
kezhenxu94
kezhenxu94 previously approved these changes Mar 21, 2026
Comment on lines +37 to +43
## Fixing "action is not allowed" errors

If a CI run or PR is blocked because a GitHub Action is not on the Apache allow list:

1. **Check the approved list**: https://github.com/apache/infrastructure-actions/blob/main/approved_patterns.yml
2. **Update the workflow**: Replace the version tag (e.g., `@v3`) with the approved SHA pin from the list.
3. Actions owned by `actions/*`, `github/*`, and `apache/*` are always allowed (enterprise-owned) and don't need SHA pins.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is duplicate to the content in CLAUDE.md in root folder, as CLAUDE.md in the root folder will always be loaded, this section here doesn't do much than spending some tokens.

The frontend was dropping 312K+ spans due to maxQueueSize reached,
likely caused by memory pressure from the 200M limit on Node.js.
The productcatalogservice had only 20M which is very tight for a
Go service with gRPC + OTLP export.

Also remove duplicate GitHub Actions allow list section from
ci-e2e-debug skill per review comment (already in CLAUDE.md).
@wu-sheng wu-sheng merged commit 5806ff2 into master Mar 22, 2026
186 checks passed
@wu-sheng wu-sheng deleted the fix/pin-docker-actions-to-approved-shas branch March 22, 2026 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Assistant Claude and other AI Coding Tooling CI settings CI settings adjustment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants