Skip to content

Debugging instructions simplified#24

Open
jtulach wants to merge 4 commits intoapache:masterfrom
jtulach:DebugInvokesCode
Open

Debugging instructions simplified#24
jtulach wants to merge 4 commits intoapache:masterfrom
jtulach:DebugInvokesCode

Conversation

@jtulach
Copy link
Contributor

@jtulach jtulach commented Feb 4, 2026

vscode$ npm run nbcode
  • shall be everything one needs to debug Java running in code
    • the code is started with fresh data and extension directories
    • as such it should be isolated enough from any personal setup
  • I am able to install enso.vsix into the started code instance and then debug both
  • I am debugging from NetBeans IDE attaching to port 8000

@dbalek
Copy link
Contributor

dbalek commented Feb 6, 2026

Is there any chance to change the debug port if necessary? I saw it is hard coded in the sources now.

@jtulach
Copy link
Contributor Author

jtulach commented Feb 6, 2026

Is there any chance to change the debug port if necessary? I saw it is hard coded in the sources now.

  • thanks for review, Dušane
  • one change of this PR is that debugging is on by default when doing npm run nbcode
    • OK?
    • if so, we need default port - is 8000 OK?
  • if you want to change the port, then we need a way to take action
    • right now the action is go to the src/nbcode.ts and change the code, btw.
    • should such an action be npm run nbcode port=7777?
    • or it should be port=7777 npm run nbcode?
    • or do you propose something else?

@dbalek
Copy link
Contributor

dbalek commented Feb 6, 2026

* one change of this PR is that debugging is on by default when doing `npm run nbcode`
  * OK?
  * if so, we need default port - is 8000 OK?

To have debugging on by default when running npm run nbcode is OK for me together with using 8000 as the default port.

* if you want to change the port, then we need a way to take action
  
  * right now the action is go to the `src/nbcode.ts` and change the code, btw.
  * should such an action be `npm run nbcode port=7777`?
  * or it should be `port=7777 npm run nbcode`?
  * or do you propose something else?

Either of the proposed solutions should be IMHO better than the necessity to modify the extension's sources to start debugging on a non-default port.

@jtulach
Copy link
Contributor Author

jtulach commented Mar 12, 2026

To have debugging on by default when running npm run nbcode is OK for me together with using 8000 as the default port.
Either ... solutions ... better than the necessity to modify the extension's sources to start debugging on a non-default port.

Done in e2b450b

@jtulach
Copy link
Contributor Author

jtulach commented Mar 12, 2026

  • thanks for the review.
  • test-vscode-ext is failing and will also need a fix

@MartinBalin
Copy link
Contributor

Will fix the JDK17 test to use 21 after the release. It is caused by the fact that I've changes netbeans submodule in master to commit in NB master where 21 is already required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants