Conversation
git-svn-id: https://svn.apache.org/repos/asf/incubator/libcloud/trunk@909101 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/incubator/libcloud/trunk@909105 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/incubator/libcloud/trunk@909275 13f79535-47bb-0310-9956-ffa450edef68
…via IRC by Upayavira git-svn-id: https://svn.apache.org/repos/asf/incubator/libcloud/trunk@910771 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/incubator/libcloud/trunk@910776 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/incubator/libcloud/trunk@911663 13f79535-47bb-0310-9956-ffa450edef68
…s consistent. git-svn-id: https://svn.apache.org/repos/asf/incubator/libcloud/trunk@911983 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/incubator/libcloud/trunk@915434 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/incubator/libcloud/trunk@915435 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/incubator/libcloud/trunk@915436 13f79535-47bb-0310-9956-ffa450edef68
…st logger to support HTTP in addition to HTTPS git-svn-id: https://svn.apache.org/repos/asf/incubator/libcloud/trunk@915562 13f79535-47bb-0310-9956-ffa450edef68
…eused between multiple objects. git-svn-id: https://svn.apache.org/repos/asf/incubator/libcloud/trunk@915692 13f79535-47bb-0310-9956-ffa450edef68
…h r915692. git-svn-id: https://svn.apache.org/repos/asf/incubator/libcloud/trunk@915693 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/incubator/libcloud/trunk@916487 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/incubator/libcloud/trunk@916895 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/incubator/libcloud/trunk@916896 13f79535-47bb-0310-9956-ffa450edef68
…than doing any of this inline git-svn-id: https://svn.apache.org/repos/asf/incubator/libcloud/trunk@917333 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/incubator/libcloud/trunk@917334 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/incubator/libcloud/trunk@917335 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/incubator/libcloud/trunk@917338 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/incubator/libcloud/trunk@917477 13f79535-47bb-0310-9956-ffa450edef68
…working. git-svn-id: https://svn.apache.org/repos/asf/incubator/libcloud/trunk@917724 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/incubator/libcloud/trunk@917725 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/incubator/libcloud/trunk@917738 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/incubator/libcloud/trunk@917739 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/incubator/libcloud/trunk@917740 13f79535-47bb-0310-9956-ffa450edef68
…ecrease it from 10 seconds to 3 seconds. git-svn-id: https://svn.apache.org/repos/asf/incubator/libcloud/trunk@917913 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/incubator/libcloud/trunk@918180 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/incubator/libcloud/trunk@919879 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/incubator/libcloud/trunk@919884 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/incubator/libcloud/trunk@985057 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/incubator/libcloud/trunk@985058 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/incubator/libcloud/trunk@985062 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/incubator/libcloud/trunk@985063 13f79535-47bb-0310-9956-ffa450edef68
Submitted by: Davanum Srinivas <davanum gmail.com> git-svn-id: https://svn.apache.org/repos/asf/incubator/libcloud/trunk@985069 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/incubator/libcloud/trunk@985104 13f79535-47bb-0310-9956-ffa450edef68
To reduce load on the Linode API, batch together requests for the IP addresses on each Linode. Also modify the tests and supporting methods to accept batched responses. git-svn-id: https://svn.apache.org/repos/asf/incubator/libcloud/trunk@985783 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/incubator/libcloud/trunk@987252 13f79535-47bb-0310-9956-ffa450edef68
…dn't take self anyways, Fixing LIBCLOUD-47 Submitted by: Tomaz Muraus <tomaz cloudkick.com> git-svn-id: https://svn.apache.org/repos/asf/incubator/libcloud/trunk@987774 13f79535-47bb-0310-9956-ffa450edef68
…ovision_pending, 13=Restart_pending. git-svn-id: https://svn.apache.org/repos/asf/incubator/libcloud/trunk@990815 13f79535-47bb-0310-9956-ffa450edef68
|
plus 1. I needed this feature for deploy_node and can confirm it works. |
|
It's been almost 10 months since the last commit in this pull request. How about closing this pull request and encouraging the participants to submit smaller pull request(s) that are based on the current code base? |
Author
|
I'd say it's beyond obvious that this repository is not working within the standard Github workflow, and is really meant just as a mirror of the official repository. I am not currently using libcloud for anything, and don't care to maintain the fork or update the patch to work with the current code base. |
Phreedom
added a commit
to Phreedom/libcloud
that referenced
this pull request
Jun 30, 2014
…argetpool: multiple bugfixes Fix apache#1: targetpool = driver.ex_get_targetpool('tpname') targetpool.add_node(node) node.destroy() # targetpool still contains the node targetpool = driver.ex_get_targetpool('tpname') # targetpool.nodes contains node uri string (in addition to possible other node objects) # as produced by _to_targetpool because the node is in the pool but is destroyed targetpool.remove_node(node) # raises an exception, removes the node nevertheless. Expected behavior: remove the node, return true Fix apache#2: targetpool.add(node) targetpool.add(node) # targetpool.nodes contains 2 copies of node # actual targetpool resource on the GCE side doesn't contain 2 copies Expected behavior: no duplicates in targetpool.nodes, the node list matches GCE side Fix/Improvement apache#3: Allow specifying nodes by fully-qualified node uri in add_node and remove_node. if tp.nodes: tp.remove_node(tp.nodes[0]) # fails if the node in the list doesn't exist exoected behavior: should be able to remove any node from the list GCE allows adding non-existent nodes to the targetpool and doesn't automatically remove nodes from the pool if you delete them. libcloud should support doing the same.
Phreedom
added a commit
to Phreedom/libcloud
that referenced
this pull request
Sep 16, 2014
…argetpool: multiple bugfixes Fix apache#1: targetpool = driver.ex_get_targetpool('tpname') targetpool.add_node(node) node.destroy() # targetpool still contains the node targetpool = driver.ex_get_targetpool('tpname') # targetpool.nodes contains node uri string (in addition to possible other node objects) # as produced by _to_targetpool because the node is in the pool but is destroyed targetpool.remove_node(node) # raises an exception, removes the node nevertheless. Expected behavior: remove the node, return true Fix apache#2: targetpool.add(node) targetpool.add(node) # targetpool.nodes contains 2 copies of node # actual targetpool resource on the GCE side doesn't contain 2 copies Expected behavior: no duplicates in targetpool.nodes, the node list matches GCE side Fix/Improvement apache#3: Allow specifying nodes by fully-qualified node uri in add_node and remove_node. if tp.nodes: tp.remove_node(tp.nodes[0]) # fails if the node in the list doesn't exist exoected behavior: should be able to remove any node from the list GCE allows adding non-existent nodes to the targetpool and doesn't automatically remove nodes from the pool if you delete them. libcloud should support doing the same.
asfgit
pushed a commit
that referenced
this pull request
Sep 20, 2014
…argetpool: multiple bugfixes Fix #1: targetpool = driver.ex_get_targetpool('tpname') targetpool.add_node(node) node.destroy() # targetpool still contains the node targetpool = driver.ex_get_targetpool('tpname') # targetpool.nodes contains node uri string (in addition to possible other node objects) # as produced by _to_targetpool because the node is in the pool but is destroyed targetpool.remove_node(node) # raises an exception, removes the node nevertheless. Expected behavior: remove the node, return true Fix #2: targetpool.add(node) targetpool.add(node) # targetpool.nodes contains 2 copies of node # actual targetpool resource on the GCE side doesn't contain 2 copies Expected behavior: no duplicates in targetpool.nodes, the node list matches GCE side Fix/Improvement #3: Allow specifying nodes by fully-qualified node uri in add_node and remove_node. if tp.nodes: tp.remove_node(tp.nodes[0]) # fails if the node in the list doesn't exist exoected behavior: should be able to remove any node from the list GCE allows adding non-existent nodes to the targetpool and doesn't automatically remove nodes from the pool if you delete them. libcloud should support doing the same. Signed-off-by: Tomaz Muraus <tomaz@apache.org>
snmpboy
pushed a commit
to snmpboy/libcloud
that referenced
this pull request
Oct 24, 2018
changes made to get the VMware tools status.
asfgit
pushed a commit
that referenced
this pull request
Dec 6, 2020
…tures Add new accounts features for outscale provider
asfgit
pushed a commit
that referenced
this pull request
Jan 28, 2022
Fix SignedHeaders for Scaleway Provider
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the Rackspace driver, create_node() and deploy_node() return different node references unnecessarily. The create_node() method returns a node instance with password populated in extra, while deploy_node() returns a node from list_nodes(), which does not include passwords. I've modified base.NodeDriver.deploy_node() to return the node instance it gets from calling create_node(), thus including the password.
I've also modified drivers.rackspace.RackspaceNodeDriver and added set_password() and set_server_name() methods, along with a private implementation method and modifying request() to make PUT use xml. These changes expand the API to make available the Rackspace API methods for changing the password and server name.