Skip to content

Conversation

@OneSizeFitsQuorum
Copy link
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum commented Jul 7, 2021

In the current implementation, the template-based time series is restored by calling the getMNodes function after a restart. However, the getMNodes function currently does not support template lookup and this needs to be fixed.

@coveralls
Copy link

coveralls commented Jul 7, 2021

Coverage Status

Coverage increased (+0.05%) to 68.159% when pulling b162ff2 on fix_template_restart_bug into 2784603 on master.

@OneSizeFitsQuorum OneSizeFitsQuorum marked this pull request as draft July 8, 2021 14:35
@OneSizeFitsQuorum OneSizeFitsQuorum marked this pull request as ready for review July 12, 2021 06:44
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@HTHou HTHou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@wangchao316 wangchao316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OneSizeFitsQuorum
Copy link
Contributor Author

LGTM

Hi, it seems that the failure of E2E test has nothing to do with this PR, but with PR 3292. Could you please check what the problem is?
image

@HTHou HTHou merged commit a42f2b4 into master Jul 12, 2021
@HTHou HTHou deleted the fix_template_restart_bug branch July 12, 2021 09:19
sailing27 pushed a commit to sailing27/iotdb that referenced this pull request Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants