Skip to content

Conversation

@wangchao316
Copy link
Member

@wangchao316 wangchao316 commented May 21, 2021

In some scenarios, the super user needs to be specified based on the environment. Extract the super user and password to the config

@wangchao316 wangchao316 marked this pull request as ready for review May 21, 2021 07:03
@wangchao316
Copy link
Member Author

@LebronAl @neuyilan @mychaow hi, could you please review?
Thanks

Copy link
Member

@neuyilan neuyilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
Only minor issues, PTAL.

Copy link
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OneSizeFitsQuorum OneSizeFitsQuorum merged commit bcce61b into apache:master May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants