Core: Allow reading metadata table when scanning table with dropped partition source field #14089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huaxingao
reviewed
Sep 17, 2025
| builder.add(newFieldId, newFieldId, field.name(), Transforms.identity()); | ||
| } | ||
| return builder.build(); | ||
| return builder.build(true); |
Contributor
There was a problem hiding this comment.
Please add a short comment to explain why we intentionally bypass the compatibility check here
Fokko
approved these changes
Sep 17, 2025
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
I agree with @huaxingao that a comment would be nice there, apart from that, LGTM! 👍
gabeiglio
force-pushed
the
fix-corrupted-metadata-table
branch
from
261f814 to
2a0341d
Compare
Contributor
Author
|
@huaxingao @Fokko thanks for the review! Added a comment 👍🏼 |
singhpk234
approved these changes
Sep 17, 2025
Contributor
singhpk234
left a comment
singhpk234
left a comment
There was a problem hiding this comment.
Thank you for the fix @gabeiglio ! LGTM as well
bryanck
approved these changes
Sep 17, 2025
huaxingao
approved these changes
Sep 17, 2025
Contributor
|
Thank you for the fix @gabeiglio ! Thank you for the reviews @Fokko @huaxingao @bryanck ! |
fbertsch
pushed a commit
to fbertsch/iceberg
that referenced
this pull request
Jan 19, 2026
…artition source field (apache#14089) (apache#841) Co-authored-by: Gabriel Igliozzi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To replicate this issue run the following spark queries: