Centralized table properties management#388
Merged
Fokko merged 3 commits intoapache:mainfrom Feb 8, 2024
Merged
Conversation
Fokko
reviewed
Feb 7, 2024
kevinjqliu
reviewed
Feb 7, 2024
Contributor
Author
@kevinjqliu Thanks for the review! According to #365 (comment), the purpose of putting properties in |
Fokko
approved these changes
Feb 8, 2024
Contributor
|
This is much better, thanks @HonahX for working on this. Let's get this in, so we don't break the references later on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #365
My initial plan was to add the names and defaults of all table properties. However, upon further consideration, I think it may be better to add properties as needed.