chore: replace debug-statements hook with ruff T100 #2954
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinjqliu
approved these changes
Jan 26, 2026
Contributor
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
Thanks!
looks like debug-statements is redundant
https://github.com/pre-commit/pre-commit-hooks?tab=readme-ov-file#debug-statements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Like #2953, doing a dive into the linted dependencies we can replace the
debug-statementspre-commit hook with ruff'sT100rule flake8-debugger.This will lighten the linters needed when working on cb.
T100 catches more modern debuggers (
debugpy,ptvsd,IPython.embed). It seems like there are rare debuggers it misses but aren't used likebpdb.Are these changes tested?
make lintAre there any user-facing changes?
No