Merged
Conversation
added 3 commits
December 19, 2024 00:19
kevinjqliu
reviewed
Dec 19, 2024
Contributor
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
Added a few comments, please take a look! The PR looks great already. Thanks for working on this!
Fokko
reviewed
Dec 20, 2024
Fokko
reviewed
Dec 20, 2024
…tion logic to helper method, changed test to use high-level table scan
Fokko
reviewed
Dec 29, 2024
Fokko
reviewed
Dec 29, 2024
Fokko
reviewed
Dec 29, 2024
Fokko
reviewed
Dec 29, 2024
kevinjqliu
reviewed
Jan 3, 2025
kevinjqliu
reviewed
Jan 7, 2025
Fokko
reviewed
Jan 13, 2025
kevinjqliu
reviewed
Jan 20, 2025
Contributor
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
generally LGTM! I added a few nit comments and some clarifying questions on testing.
thanks for working on this!
kevinjqliu
reviewed
Feb 1, 2025
Contributor
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
Looks like CI caught an interesting case where a new identity partition is added after data files were written. The accessor then cannot find the proper partition record... We need to do something like this
kevinjqliu
approved these changes
Feb 5, 2025
Contributor
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM! Thanks @gabeiglio !!
Fokko
approved these changes
Feb 10, 2025
Contributor
|
Thanks for working on this @gabeiglio, and thanks for the review @kevinjqliu 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for issue #1401. In which table scans needed to infer partition column by following the column projection rules
Fixes #1401