Skip to content

LaxConnPool: Deallocate pool entry upon discarding expired connection#643

Merged
rschmitt merged 1 commit intoapache:masterfrom
rschmitt:lax
Feb 27, 2026
Merged

LaxConnPool: Deallocate pool entry upon discarding expired connection#643
rschmitt merged 1 commit intoapache:masterfrom
rschmitt:lax

Conversation

@rschmitt
Copy link
Contributor

This will be backported to the 5.4.x branch.

Copy link
Member

@arturobernalg arturobernalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch—thanks for fixing the allocation leak

@rschmitt rschmitt merged commit 23bb1c8 into apache:master Feb 27, 2026
10 checks passed
@rschmitt rschmitt deleted the lax branch February 27, 2026 20:18
@rschmitt
Copy link
Contributor Author

By the way, it appears that STRICT (the default) and OFFLOCK do not exhibit this issue, but I wouldn't mind if someone wanted to double-check. This is the third LaxConnPool bug and the fourth pooling bug overall I've found in the last month, so we should think about implementing some sort of souped-up testing strategy like generative contract testing (i.e. run a common set of fuzz tests on all three implementations and check appropriate invariants).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants