Skip to content

FINERACT-2549: Migrate InstanceModeIntegrationTest from RestAssured to fineract-client-feign#5658

Open
Dpk376 wants to merge 3 commits intoapache:developfrom
Dpk376:feature/FINERACT-2441-feign-migration
Open

FINERACT-2549: Migrate InstanceModeIntegrationTest from RestAssured to fineract-client-feign#5658
Dpk376 wants to merge 3 commits intoapache:developfrom
Dpk376:feature/FINERACT-2441-feign-migration

Conversation

@Dpk376
Copy link

@Dpk376 Dpk376 commented Mar 20, 2026

What this PR does

Migrates InstanceModeIntegrationTest from the deprecated RestAssured-based
helpers to the typed fineract-client-feign client, as part of FINERACT-2549.

Changes

  • SchedulerJobHelper: Added no-arg constructor; replaced getSchedulerJobIdByShortName
    and runSchedulerJob with feign-based implementations using FineractClientHelper
  • InstanceModeIntegrationTest: Removed all RestAssured boilerplate (requestSpec,
    responseSpec, Utils.initializeRESTAssured()); migrated ClientHelper.createClient
    and schedulerJobHelper.runSchedulerJob calls to feign; error cases now use
    assertThrows(CallFailedRuntimeException.class, ...)

Checklist

  • ./gradlew spotlessApply passed
  • ./gradlew :integration-tests:compileTestJava passed
  • No new RestAssured dependencies introduced

Part of FINERACT-2549
Related to FINERACT-2454

gsoc-fineract-evidence

@DeathGun44
Copy link
Contributor

@Dpk376 please make sure to sign your commits ,refer [‎CONTRIBUTING.md]. Also Fineract-2441 points to BI connector and demonstration ,please create a separate issue to properly track this via JIRA.

@Dpk376 Dpk376 changed the title FINERACT-2441: Migrate InstanceModeIntegrationTest from RestAssured to fineract-client-feign FINERACT-2454: Migrate InstanceModeIntegrationTest from RestAssured to fineract-client-feign Mar 20, 2026
@Dpk376 Dpk376 force-pushed the feature/FINERACT-2441-feign-migration branch 2 times, most recently from c5c0d9b to 396e5ff Compare March 20, 2026 12:06
@Dpk376 Dpk376 force-pushed the feature/FINERACT-2441-feign-migration branch from 396e5ff to 6e4dabb Compare March 20, 2026 12:14
@Dpk376 Dpk376 closed this Mar 20, 2026
@Dpk376 Dpk376 reopened this Mar 20, 2026
@Dpk376
Copy link
Author

Dpk376 commented Mar 20, 2026

@Dpk376 please make sure to sign your commits ,refer [‎CONTRIBUTING.md]. Also Fineract-2441 points to BI connector and demonstration ,please create a separate issue to properly track this via JIRA.

Hi @DeathGun44 , thanks for the feedback!

Commit signatures: All commits are now GPG-signed and verified. You can see the "Verified" badge on each commit.
JIRA ticket: Agreed — I've updated the PR to reference FINERACT-2454 ("fineract-client-feign usage for integration tests"), which is the correct ticket tracking this migration work. FINERACT-2441 has been removed from all commit messages and the PR title.
Let me know if there's anything else to address!

@DeathGun44
Copy link
Contributor

@Dpk376 This is a GSoC ticket .the ticket clearly mentions "No one should work on this specific ticket unless assigned - the GSOC candidate we choose will be assigned this ticket." so your pr description closes #FINERACT-2454 doesn;t make sense, please create a separate jira ticket if you want to work on this for a PoC or otherwise.

@Dpk376
Copy link
Author

Dpk376 commented Mar 21, 2026

@Dpk376 This is a GSoC ticket .the ticket clearly mentions "No one should work on this specific ticket unless assigned - the GSOC candidate we choose will be assigned this ticket." so your pr description closes #FINERACT-2454 doesn;t make sense, please create a separate jira ticket if you want to work on this for a PoC or otherwise.

Hi @DeathGun44, thank you for the clarification — I understand now that FINERACT-2454 is the GSoC tracking ticket and should not be closed by contributor PRs. I'll create a separate Jira ticket for this test migration work and update both PRs accordingly. Appreciate the heads up!

@Dpk376 Dpk376 changed the title FINERACT-2454: Migrate InstanceModeIntegrationTest from RestAssured to fineract-client-feign FINERACT-2549: Migrate InstanceModeIntegrationTest from RestAssured to fineract-client-feign Mar 21, 2026
@Dpk376
Copy link
Author

Dpk376 commented Mar 21, 2026

@Dpk376 This is a GSoC ticket .the ticket clearly mentions "No one should work on this specific ticket unless assigned - the GSOC candidate we choose will be assigned this ticket." so your pr description closes #FINERACT-2454 doesn;t make sense, please create a separate jira ticket if you want to work on this for a PoC or otherwise.

I've created a separate JIRA ticket [FINERACT-2549] to properly track this test migration work and updated both PRs to reference it instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants