[ISSUE #3903] Unwritten public or protected field [HeartbeatRequestBody]#4757
[ISSUE #3903] Unwritten public or protected field [HeartbeatRequestBody]#4757mxsm merged 2 commits intoapache:masterfrom AaronGhebretinsae:master
Conversation
…artbeatRequestBody.java. updated EventMeshHttpConsumer.java to access aforementioned variables using correct setters. Updated HeartbeatProcessor.java to access aforementioned variables using correct getters.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to the Apache EventMesh community!!
This is your first PR in our project. We're very excited to have you onboard contributing. Your contributions are greatly appreciated!
Please make sure that the changes are covered by tests.
We will be here shortly.
Let us know if you need any help!
Want to get closer to the community?
| WeChat Assistant | WeChat Public Account | Slack |
|---|---|---|
 |
 |
Join Slack Chat |
Mailing Lists:
| Name | Description | Subscribe | Unsubscribe | Archive |
|---|---|---|---|---|
| Users | User support and questions mailing list | Subscribe | Unsubscribe | Mail Archives |
| Development | Development related discussions | Subscribe | Unsubscribe | Mail Archives |
| Commits | All commits to repositories | Subscribe | Unsubscribe | Mail Archives |
| Issues | Issues or PRs comments and reviews | Subscribe | Unsubscribe | Mail Archives |
mxsm
left a comment
mxsm
left a comment
There was a problem hiding this comment.
@AaronGhebretinsae Welcome to Apache EventMesh community, thanks for your contribution. please link this pr to the target issue.How to do this?You can refer to the submitted PR for more details.
| public String getTopic() { | ||
| return topic; | ||
| } | ||
|
|
||
| public void setTopic(String topic) { | ||
| this.topic = topic; | ||
| } | ||
|
|
||
| public String getServiceId() { | ||
| return serviceId; | ||
| } | ||
|
|
||
| public void setServiceId(String serviceId) { | ||
| this.serviceId = serviceId; | ||
| } | ||
|
|
||
| public String getUrl() { | ||
| return url; | ||
| } | ||
|
|
||
| public void setUrl(String url) { | ||
| this.url = url; | ||
| } | ||
|
|
||
| public String getInstanceId() { | ||
| return instanceId; | ||
| } | ||
|
|
||
| public void setInstanceId(String instanceId) { | ||
| this.instanceId = instanceId; | ||
| } |
There was a problem hiding this comment.
This code is unnecessary. because you has used the @Data annotation.
There was a problem hiding this comment.
I removed the extraneous code.
…/java/org/apache/eventmesh/common/protocol/http/body/client/HeartbeatRequestBody.java >
|
I have also linked the PR to the target issue |
xwm1992
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4757 +/- ##
============================================
+ Coverage 17.59% 17.61% +0.01%
- Complexity 1774 1783 +9
============================================
Files 797 805 +8
Lines 29786 29925 +139
Branches 2573 2581 +8
============================================
+ Hits 5242 5270 +28
- Misses 24063 24172 +109
- Partials 481 483 +2 ☔ View full report in Codecov by Sentry. |
…uestBody] (apache#4757) * added appropriate getters and setters for HeartbeatEntity class in HeartbeatRequestBody.java. updated EventMeshHttpConsumer.java to access aforementioned variables using correct setters. Updated HeartbeatProcessor.java to access aforementioned variables using correct getters. * <Removed unnecessary getters and setters in eventmesh-common/src/main/java/org/apache/eventmesh/common/protocol/http/body/client/HeartbeatRequestBody.java >
4 participants
Fixes #3903
Motivation
I am currently new to open source contributing and would like to gain experience solving issues and navigating git in order to become a better contributor.
Modifications
-Added appropriate getters and setters for HeartbeatEntity class in HeartbeatRequestBody.java.
-Updated EventMeshHttpConsumer.java to access aforementioned variables using correct setters.
-Updated HeartbeatProcessor.java to access aforementioned variables using correct getters.
Documentation
At eventmesh-common/src/main/java/org/apache/eventmesh/common/protocol/http/body/client/HeartbeatRequestBody.java line 70-75
At eventmesh-sdk
java/src/main/java/org/apache/eventmesh/client/http/consumer/EventMeshHttpConsumer.java line 120,121
At eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/HeartBeatProcessor.java line 115,116
resolves #3903