Skip to content

[ISSUE #4085] Switching order#4338

Merged
mxsm merged 1 commit intoapache:masterfrom
Kouzola:master
Aug 7, 2023
Merged

[ISSUE #4085] Switching order#4338
mxsm merged 1 commit intoapache:masterfrom
Kouzola:master

Conversation

@Kouzola
Copy link
Contributor

@Kouzola Kouzola commented Aug 6, 2023

Fixes #4085
I switched the order of the argument for the method assertEquals in the MessageUtilsTest.java

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the Apache EventMesh community!!
This is your first PR in our project. We're very excited to have you onboard contributing. Your contributions are greatly appreciated!

Please make sure that the changes are covered by tests.
We will be here shortly.
Let us know if you need any help!

Want to get closer to the community?

WeChat Assistant WeChat Public Account Slack
Join Slack Chat

Mailing Lists:

Name Description Subscribe Unsubscribe Archive
Users User support and questions mailing list Subscribe Unsubscribe Mail Archives
Development Development related discussions Subscribe Unsubscribe Mail Archives
Commits All commits to repositories Subscribe Unsubscribe Mail Archives
Issues Issues or PRs comments and reviews Subscribe Unsubscribe Mail Archives

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kouzola Good job! please use fix to link this pr to issue

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #4338 (670fed7) into master (800b628) will not change coverage.
The diff coverage is n/a.

❗ Current head 670fed7 differs from pull request most recent head adbcb58. Consider uploading reports for the commit adbcb58 to get more accurate results

@@            Coverage Diff            @@
##             master    #4338   +/-   ##
=========================================
  Coverage     16.35%   16.35%           
  Complexity     1362     1362           
=========================================
  Files           594      594           
  Lines         25393    25393           
  Branches       2393     2393           
=========================================
  Hits           4152     4152           
  Misses        20818    20818           
  Partials        423      423           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@Pil0tXia Pil0tXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshithasudhakar
Copy link
Member

LGTM

@mxsm mxsm merged commit 9d67039 into apache:master Aug 7, 2023
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Switching order: expected value, actual value.[MessageUtilsTest]

6 participants