Skip to content

[ISSUE #4264][Enhancement] Some optimizations for ProducerService#4334

Merged
mxsm merged 1 commit intoapache:masterfrom
847850277:Enhancement_Some_optimizations_for_ProducerService._#4264_
Aug 5, 2023
Merged

[ISSUE #4264][Enhancement] Some optimizations for ProducerService#4334
mxsm merged 1 commit intoapache:masterfrom
847850277:Enhancement_Some_optimizations_for_ProducerService._#4264_

Conversation

@847850277
Copy link
Contributor

Fixes #4264.

1、Make field non-public and provide accessors if needed.
2、Restore interrupted state

@847850277 847850277 changed the title [ISSUE #4264]Some optimizations for ProducerService [ISSUE #4264][Enhancement] Some optimizations for ProducerService Aug 5, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the Apache EventMesh community!!
This is your first PR in our project. We're very excited to have you onboard contributing. Your contributions are greatly appreciated!

Please make sure that the changes are covered by tests.
We will be here shortly.
Let us know if you need any help!

Want to get closer to the community?

WeChat Assistant WeChat Public Account Slack
Join Slack Chat

Mailing Lists:

Name Description Subscribe Unsubscribe Archive
Users User support and questions mailing list Subscribe Unsubscribe Mail Archives
Development Development related discussions Subscribe Unsubscribe Mail Archives
Commits All commits to repositories Subscribe Unsubscribe Mail Archives
Issues Issues or PRs comments and reviews Subscribe Unsubscribe Mail Archives

@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Merging #4334 (70866ae) into master (19dd2b1) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 70866ae differs from pull request most recent head 689e295. Consider uploading reports for the commit 689e295 to get more accurate results

@@            Coverage Diff            @@
##             master    #4334   +/-   ##
=========================================
  Coverage     16.35%   16.35%           
- Complexity     1362     1363    +1     
=========================================
  Files           594      594           
  Lines         25393    25393           
  Branches       2393     2393           
=========================================
+ Hits           4152     4154    +2     
+ Misses        20818    20817    -1     
+ Partials        423      422    -1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@Pil0tXia Pil0tXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxsm
Copy link
Member

mxsm commented Aug 5, 2023

@847850277 thanks for your contribution

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxsm mxsm merged commit 800b628 into apache:master Aug 5, 2023
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Some optimizations for ProducerService.

4 participants