Skip to content

[ISSUE #4260] Anonymous new ChannelFutureListener() can be replaced with lambda[HelloTask]#4316

Merged
xwm1992 merged 4 commits intoapache:masterfrom
sbmvirdi:master
Aug 2, 2023
Merged

[ISSUE #4260] Anonymous new ChannelFutureListener() can be replaced with lambda[HelloTask]#4316
xwm1992 merged 4 commits intoapache:masterfrom
sbmvirdi:master

Conversation

@sbmvirdi
Copy link
Contributor

@sbmvirdi sbmvirdi commented Aug 1, 2023

Fixes #4260 .

Motivation

To contribute in open source

Modifications

Updated: ChannelFutureListener to lambda expression as its a functional Interface

Documentation

  • Does this pull request introduce a new feature? No
  • If yes, how is the feature documented? not applicable
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@sbmvirdi sbmvirdi changed the title [4260] Fixed: Anonymous new ChannelFutureListener() can be replaced [4260] Fixed: Anonymous new ChannelFutureListener() can be replaced with lambda[HelloTask] Aug 1, 2023
@mxsm mxsm changed the title [4260] Fixed: Anonymous new ChannelFutureListener() can be replaced with lambda[HelloTask] [ISSUE #4260] Fixed: Anonymous new ChannelFutureListener() can be replaced with lambda[HelloTask] Aug 2, 2023
Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbmvirdi Please remove the useless import
image

@sbmvirdi sbmvirdi requested a review from mxsm August 2, 2023 04:30
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #4316 (07adad3) into master (dd40227) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head 07adad3 differs from pull request most recent head c05f0ed. Consider uploading reports for the commit c05f0ed to get more accurate results

@@            Coverage Diff            @@
##             master    #4316   +/-   ##
=========================================
  Coverage     16.35%   16.36%           
- Complexity     1359     1360    +1     
=========================================
  Files           594      594           
  Lines         25419    25418    -1     
  Branches       2394     2393    -1     
=========================================
+ Hits           4158     4160    +2     
+ Misses        20838    20836    -2     
+ Partials        423      422    -1     
Files Changed Coverage Δ
...ntime/core/protocol/tcp/client/task/HelloTask.java 0.00% <ø> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xwm1992 xwm1992 changed the title [ISSUE #4260] Fixed: Anonymous new ChannelFutureListener() can be replaced with lambda[HelloTask] [ISSUE #4260] Anonymous new ChannelFutureListener() can be replaced with lambda[HelloTask] Aug 2, 2023
@xwm1992 xwm1992 merged commit fef56a5 into apache:master Aug 2, 2023
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
…aced with lambda[HelloTask] (apache#4316)

* [4260] Fixed: Anonymous new ChannelFutureListener() can be replaced with lambda[HelloTask]

* Upgraded: First Interaction Action Version to Latest

* [4260] Removed: Unused Import

* Update package import order in HelloTask.java

---------

Co-authored-by: mike_xwm <mike_xwm@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Anonymous new ChannelFutureListener() can be replaced with lambda[HelloTask]

4 participants