[ISSUE #4093]Repeat code extraction as method.[MessageUtils]#4315
Merged
mxsm merged 2 commits intoapache:masterfrom Aug 2, 2023
Merged
[ISSUE #4093]Repeat code extraction as method.[MessageUtils]#4315mxsm merged 2 commits intoapache:masterfrom
mxsm merged 2 commits intoapache:masterfrom
Conversation
mxsm
changed the title
Codecov Report
@@ Coverage Diff @@
## master #4315 +/- ##
=========================================
Coverage 16.35% 16.35%
- Complexity 1359 1363 +4
=========================================
Files 594 594
Lines 25419 25392 -27
Branches 2394 2394
=========================================
- Hits 4158 4154 -4
+ Misses 20838 20816 -22
+ Partials 423 422 -1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xwm1992
approved these changes
Aug 2, 2023
xuhongjia
pushed a commit
to Deckers-Ohana/eventmesh
that referenced
this pull request
Mar 13, 2025
…pache#4315) * [ISSUE apache#4093]: Refactor package building chunks to reusable method * [ISSUE apache#4093]: Refactor user agent building chunks to reusable method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4093.
Motivation
There were some duplicated logic within different methods in MessageUtils.
Modifications
Move reusable logics to separate method and make use of those methods where applicable
Documentation