Add serde support for Arrow FileTypeWriterOptions#8850
Merged
alamb merged 9 commits intoapache:mainfrom Jan 18, 2024
Merged
Conversation
9 tasks
alamb
approved these changes
Jan 18, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @tushushu -- this PR makes sense to me. I realize it is somewhat strange that there are no fields yet but once they are added I think this PR has all the plumbing in place to add them to seriailzation easily.
Thank you
Contributor
|
I took the liberty of merging this branch up from main and once the CI passes I intend to merge it in |
Contributor
|
Thanks again @tushushu |
Contributor
Author
|
@alamb Thanks Andrew for reviewing the PR~ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8599.
By reading #8627 and #8641, I speculated that maybe the code should be written like this, but I'm not entirely sure if the code I wrote is correct. Maybe I should read more documentation about arrow-rs in the future.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?