Improve array_prepend signature for null and empty array#8625
Improve array_prepend signature for null and empty array#8625alamb merged 1 commit intoapache:mainfrom
array_prepend signature for null and empty array#8625Conversation
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
github-actions
bot
added
logical-expr
|
|
||
| # DuckDB: [[]] | ||
| # ClickHouse: [[]] | ||
| # TODO: We may also return [[]] |
There was a problem hiding this comment.
Unsure should we implement this, return value with larger dimension seems weird to me.
There was a problem hiding this comment.
I agree -- let's not implement this until someone asks for it explicitly
|
|
||
| # DuckDB: [null] | ||
| # ClickHouse: [null] | ||
| # TODO: We may also return [null] |
There was a problem hiding this comment.
Same with this one.
There was a problem hiding this comment.
Both cases are not considered in array_append
Weijun-H
left a comment
Weijun-H
left a comment
There was a problem hiding this comment.
LGTM! Thanks @jayzhan211 👍
And I could try to test the null for LargeList after #8569 merged.
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @jayzhan211 -- this is looking very nice. 👌
|
|
||
| # DuckDB: [[]] | ||
| # ClickHouse: [[]] | ||
| # TODO: We may also return [[]] |
There was a problem hiding this comment.
I agree -- let's not implement this until someone asks for it explicitly
|
Thank you for the review @Weijun-H |
3 participants
Which issue does this PR close?
Closes #.
Part of #7142
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?