[sqllogictest] Define output types and check them in tests#5253
Merged
alamb merged 8 commits intoapache:mainfrom Feb 17, 2023
Merged
[sqllogictest] Define output types and check them in tests#5253alamb merged 8 commits intoapache:mainfrom
alamb merged 8 commits intoapache:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4499.
Rationale for this change
Currently, the type strings in sqllogictests are ignored, and letters have no meaning to them. Also, some tests benefit, like null checks, benefit from type checking.
What changes are included in this PR?
DFColumnTypethat has more types than the original sqllite set of typesAre these changes tested?
Github actions.
Are there any user-facing changes?
No