Skip to content

Support Dictionary in InListExpr#4070

Merged
tustvold merged 2 commits intoapache:masterfrom
tustvold:in-list-dictionary
Nov 3, 2022
Merged

Support Dictionary in InListExpr#4070
tustvold merged 2 commits intoapache:masterfrom
tustvold:in-list-dictionary

Conversation

@tustvold
Copy link
Contributor

@tustvold tustvold commented Nov 1, 2022 •
edited by alamb
Loading

Draft as builds on #4057

Which issue does this PR close?

Closes #3936

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added core Core DataFusion crate physical-expr Changes to the physical-expr crates labels Nov 1, 2022
tustvold
tustvold commented Nov 1, 2022
View reviewed changes
datafusion/core/tests/sql/predicates.rs
ctx.register_batch("test", batch)?;

let sql = "SELECT * FROM test WHERE c1 IN ('foo', 'Bar', 'fazz')";
let sql = "SELECT * FROM test WHERE c1 IN ('foo', 'Bar', 'fazzz')";
Copy link
Contributor Author

@tustvold tustvold Nov 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test was previously ignored, as it failed, and was actually wrong 😆

NGA-TRAN
NGA-TRAN reviewed Nov 2, 2022
View reviewed changes
datafusion/core/tests/sql/predicates.rs
];
assert_batches_eq!(expected, &actual);
Ok(())
}
Copy link
Contributor

@NGA-TRAN NGA-TRAN Nov 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@tustvold tustvold marked this pull request as ready for review November 3, 2022 02:21
@tustvold tustvold requested a review from alamb November 3, 2022 02:21
@tustvold tustvold merged commit 61429f8 into apache:master Nov 3, 2022
@ursabot
Copy link

ursabot commented Nov 3, 2022

Benchmark runs are scheduled for baseline = 8741372 and contender = 61429f8. 61429f8 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

alamb
alamb reviewed Nov 3, 2022
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its a thing of beauty

Dandandan pushed a commit to yuuch/arrow-datafusion that referenced this pull request Nov 5, 2022
@tustvold @Dandandan
Support Dictionary in InListExpr (apache#4070)
bd01cfd 
* Support dictionary in InList (apache#3936)

* Update datafusion-cli
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alamb alamb alamb left review comments

@Dandandan Dandandan Dandandan approved these changes

+1 more reviewer

@NGA-TRAN NGA-TRAN NGA-TRAN left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

core Core DataFusion crate physical-expr Changes to the physical-expr crates

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error using IN list on dictionary encoded data: InList does not support datatype Dictionary(Int32, Utf8).

5 participants

@tustvold @ursabot @Dandandan @alamb @NGA-TRAN