feat: estimate cardinality for semi and anti-joins using distinct counts#20904
Open
buraksenn wants to merge 5 commits intoapache:mainfrom
Open
feat: estimate cardinality for semi and anti-joins using distinct counts#20904buraksenn wants to merge 5 commits intoapache:mainfrom
buraksenn wants to merge 5 commits intoapache:mainfrom
Conversation
asolimando
reviewed
Mar 12, 2026
Member
asolimando
left a comment
asolimando
left a comment
There was a problem hiding this comment.
LGTM, a couple of minor points and a few tests to be added. The only change I'd like to see is bailing out when either side has no stats for a column pair.
buraksenn
force-pushed
the
use-ndv-for-semi-and-anti-join
branch
from
a82d83e to
79dcc2b
Compare
buraksenn
force-pushed
the
use-ndv-for-semi-and-anti-join
branch
from
79dcc2b to
ee530c3
Compare
asolimando
reviewed
Mar 13, 2026
Co-authored-by: Alessandro Solimando <alessandro.solimando@gmail.com>
asolimando
approved these changes
Mar 13, 2026
Member
asolimando
left a comment
asolimando
left a comment
There was a problem hiding this comment.
LGTM, thanks for addressing all my comments fully!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Does not close but part of #20766
Rationale for this change
Details are in #20766. But main idea is to use existing distinct count information to optimize joins similar to how Spark/Trino does
What changes are included in this PR?
This PR extends cardinality estimation for semi/anti joins using distinct counts
Are these changes tested?
I've added cases but not sure if I should've added benchmarks on this.
Are there any user-facing changes?
No