Restore ability to run single SLT file#14355
Conversation
Make it possible again to run single SLT file, even if it's name is a substring of other file(s). For example, after the change, this command: cargo test --test sqllogictests -- test_files/union.slt runs `union.slt` file, but does not run `pg_compat_union.slt`.
a13c085 to
b0acc30
Compare
|
I made a small PR to your branch to show the # of files tested, verifying that
runs 2 files whereas
runs 1 file. I also verified that the sqlite tests ran without issues. |
alamb
left a comment
There was a problem hiding this comment.
Thank you @findepi ! I verified this PR using #14359
Before this PR
andrewlamb@Andrews-MacBook-Pro-2:~/Software/datafusion$ cargo test --test sqllogictests -- test_files/union.slt
Compiling datafusion-sqllogictest v44.0.0 (/Users/andrewlamb/Software/datafusion/datafusion/sqllogictest)
Finished `test` profile [unoptimized + debuginfo] target(s) in 1.14s
Running bin/sqllogictests.rs (target/debug/deps/sqllogictests-3d953efd822e1e41)
Completed 0 tests in 0 secondsAfter this PR it does
andrewlamb@Andrews-MacBook-Pro-2:~/Software/datafusion$ cargo test --test sqllogictests -- test_files/union.slt
Compiling datafusion-sqllogictest v44.0.0 (/Users/andrewlamb/Software/datafusion/datafusion/sqllogictest)
Finished `test` profile [unoptimized + debuginfo] target(s) in 1.53s
Running bin/sqllogictests.rs (target/debug/deps/sqllogictests-3d953efd822e1e41)
Completed 1 tests in 0 seconds
BTW I think it is currently possible to run a single file. For example this will run both However, it only matches on the file name (not the entire path) so using
LOL we did the same thing @Omega359 |
|
Thanks again @findepi |
Make it possible again to run single SLT file, even if it's name is a substring of other file(s).
For example, after the change, this command:
cargo test --test sqllogictests -- test_files/union.slt
runs
union.sltfile, but does not runpg_compat_union.slt.The functionality was probably accidentally lost probably in #13936
cc @Omega359